-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft patch to support Hometronic Manager HCM200d controller, HCC80R manifolds and HCW82 thermostats. #2672
base: master
Are you sure you want to change the base?
Conversation
As per the comment, the original PR was really intended just to record what I'd done rather than a serious request for merging. |
We can deal with squashing, but if you want to learn it's |
src/devices/honeywell_cm921.c
Outdated
|
||
data = decode_device_ids(msg, data, 1); | ||
data = decode_device_ids(msg, data, 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is stray whitespace at the end
This looks mostly ok, but the keys should be fixed strings and the naming ("temp_low (zone 0)") with spaces and parens is not allowed. |
The current upstream code uses the "temperature (zone X)" convention (see line 237) I've just followed the same convention when adding support for other messages. I agree it's not pretty. [note the upstream code does not register the messages.] TBH, I'm not sure decoding the "flags (zone X)", "temp_low (zone X)", "temp_high (zone X)" messages are particularly useful for any real world applications (at least they're not for mine), so I could just put support for those messages behind a #ifdef to save some of the CSV columns. Current temperature and setpoint messages are definitely needed. However, doing anything useful with the data coming out of these Honeywell systems requires a fair bit of additional code to map the temp sensors, manifold zones and controller zones and then provide useful output about the status and configuration of each zone, heat demand etc, so I'd be surprised if anyone was using CSV. LMK what you want and I'll adjust. |
Honeywell Hometronic Manager HCM200d, HCC80R manifold controller, HCW82 thermostats
These devices uses the same Ramses II protocol, but required a number of changes: