Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks a lot for an excellent SDR SW, and to @jpochmara for this driver. Just some minor cleanups.
WS90: docs: fix an error in field description
The elementary unit is 10 lux, not 10'000 lux. The expressoin and the reported value are correct, just the English text was wrong.
Fixes: f8489e9 Add support for Fineoffset WS90 (#2448)
WS90: include correct bytes in the "extra-data" field
This got garbled in the commit which added FW version discovery.
Fixes: c94ee77 Change Fineoffset-WS90 to add firmware version (#2517)
WS90: put all unknown fields into a single extra-data blob
Let's get rid of the "unknown" field which is only conditionally returned, and instead put that data into "Extra Data".
The buffer size was arbitrary, but sufficient. This change makes the buffer exactly sized for all the unknown data and the trailing
\0
.WS90: don't report supercapacitor voltage through "Extra Data"
b17
is already used for the supercapacitor voltage, so let's use a visual placeholder instead of just dumping that field.WS90: mask out the known rain sensor data in "Extra Data"