Skip to content

Commit

Permalink
Remove 100% cap for battery_lvl in fineoffset_ws90.c
Browse files Browse the repository at this point in the history
No other drivers cap the battery level, so this one should not either.

The WS90 backup power, used when the solar photovoltatic charged
supercap is empty, is provided by 2 AA batteries.

The standard manufacturer specification is that the nominal voltage of
a fresh alkaline battery is 1.5V.

The voltage of a new alkaline battery ranges from 1.50V to 1.65V,
depending on the purity of chemistry and the quality of manufacturing.

The voltage of a new lithium iron disulphide battery is 1.72V.  The
lithium iron disulphide chemistry is good down to -50C and has an
operational life of 15 years, so it is often used for weather stations
such as the WS90.

It is useful to the user to be able to see a Battery Level >100% to
let them know that they have a pair of very high quality batteries
installed and that they are fully fresh.
  • Loading branch information
fallenpegasus committed Dec 26, 2023
1 parent 83afc7b commit c062c21
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/devices/fineoffset_ws90.c
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,6 @@ static int fineoffset_ws90_decode(r_device *decoder, bitbuffer_t *bitbuffer)
int supercap_V = (b[21] & 0x3f);
int firmware = b[29];

if (battery_lvl > 100) // More then 100%?
battery_lvl = 100;

char extra[31];
snprintf(extra, sizeof(extra), "%02x%02x%02x%02x%02x------%02x%02x%02x%02x%02x%02x%02x", b[14], b[15], b[16], b[17], b[18], /* b[19,20] is the rain sensor, b[21] is supercap_V */ b[22], b[23], b[24], b[25], b[26], b[27], b[28]);

Expand Down

0 comments on commit c062c21

Please sign in to comment.