Lower the priority of normal keymap and remove some shims #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 8, 2024
Merged
|
Just tested this PR with |
|
I want to have a automatic normal/motion switching by detecting if there's an self-insert-command bound to single keys. there may be some tricky edge cases, I'll give it a try. |
DogLooksGood
force-pushed
the
low-priority-normal-keymap
branch
from
29ec89f
to
9b1bfd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All keymap in meow had the high priority by setting
emulation-mode-map-alists. In normal state, the result is every minor mode single key commands are covered by normal mode commands. We added a lot shims to work out of this, however it doesn't seems to be necessary to me.By lowering the keymap's priority, we can get rid of some shims, e.g. edebug, company, corfu, magit-blame, etc. They just work now.