Add a shim for Macrostep. #637
Merged
+75
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good. do you want to wait for @jgarte or are you ready for merge? |
|
If you've tested it and it works well then LGTM :) |
okamsn
force-pushed
the
shim-macrostep
branch
from
502eff6
to
25b8496
Compare
Macrostep shows macro expansions using overlays either in a separate buffer or at the location where the macro is used. In the overlay, it binds a local map to further expand or collapse macros. This change takes inspiration for the Beacon state and checks whether point is inside one of the overlays in `post-command-hook`. However, at least one of the commands to collapse the overlay does not seem to trigger `post-command-hook`, so switching back to the previous state is also done during `macrostep-mode-hook`.
okamsn
force-pushed
the
shim-macrostep
branch
from
25b8496
to
8c4d66c
Compare
|
I had overlooked Other than that, I think it's good now. |
|
@okamsn Thanks for your contribution. I appreciate this feature add. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macrostep shows macro expansions using overlays either in a separate buffer or at the location where the macro is used. In the overlay, it binds a local map to further expand or collapse macros.
This change takes inspiration for the Beacon state and checks whether point is inside one of the overlays in
post-command-hook. However, at least one of the commands to collapse the overlay does not seem to triggerpost-command-hook, so switching back to the previous state is also done duringmacrostep-mode-hook.macrostepwas mentioned in #503 by @jgarte. I am pinging them in case they have thoughts on this shim.