Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOO-1469] react native upgrade to 0.73.8 #141

Merged
merged 27 commits into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
316beee
feat: react native upgrade to 0.73.8
UrazAkgultan Jun 11, 2024
bb639f8
chore: upgrade RN device info
UrazAkgultan Jun 21, 2024
e76e766
chore: bump the widgets versions
UrazAkgultan Jun 21, 2024
9b23af3
fix(video-player-native): fix video player
UrazAkgultan Jun 27, 2024
0a69c37
chore: update rn gesture handler
UrazAkgultan Jun 27, 2024
149e588
chore: update gesture handler patch
Jun 27, 2024
7590041
chore: fix pwt patch
UrazAkgultan Jun 27, 2024
729d249
Adding missing @testing-library/react
NikolaSimsic Jun 28, 2024
392030b
Execute native widgets pipeline over SP & NT for RN upgrade
NikolaSimsic Jun 28, 2024
bec55be
fix(rating-native): make the widget compatible with rn 0.73.8
UrazAkgultan Jul 29, 2024
48ddbd8
fix: update test snapshots
UrazAkgultan Jul 29, 2024
2e3fd0d
fix: fix prettier
UrazAkgultan Jul 30, 2024
169fb7d
fix: fix prettier and lint
UrazAkgultan Jul 30, 2024
7981472
chore: update pluggable-widgets-tools and add explicit scrollEventThr…
vadymv-mendix Jul 31, 2024
32cb933
chore: remove RN types and regenerate snapshots in BottomSheet and In…
vadymv-mendix Aug 1, 2024
6704774
fix: avoid using jest.mock in AppEvents test
vadymv-mendix Aug 1, 2024
066770c
chore: update yarn.lock and remove unused patch
UrazAkgultan Aug 27, 2024
f4121a0
chore: update nmr changelog and version
UrazAkgultan Aug 27, 2024
89c556e
test(app-events-native): fix unit test
UrazAkgultan Aug 27, 2024
a8c43b8
chore: update yarn.lock
UrazAkgultan Aug 27, 2024
c4d5d67
fix(rating-native): replace AnimatableProps with AnimatableProperties
UrazAkgultan Aug 27, 2024
3a85673
test(progress-circle-native): update unit test snapshot
UrazAkgultan Aug 27, 2024
cbd0f58
test(gallry-native): fix failing scrolling tests
UrazAkgultan Aug 27, 2024
51ea4d5
test(rating-native): fix deprecated property name
UrazAkgultan Aug 27, 2024
85136a6
test(popup-menu-native): fix deprecated property name
UrazAkgultan Aug 27, 2024
4f0feab
refactor: remove unused lines
UrazAkgultan Aug 27, 2024
7485e75
test: revert target branch to master for Native Pipeline workflow
UrazAkgultan Aug 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/NativePipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ jobs:
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3
with:
repository: mendix/native-template
ref: master
ref: feat/react-native-upgrade-to-73.8
path: native-template
- name: "Check out code"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3
Expand Down Expand Up @@ -241,7 +241,7 @@ jobs:
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3
with:
repository: mendix/native-template
ref: master
ref: feat/react-native-upgrade-to-73.8
path: native-template
- name: "Check out code"
uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3
Expand Down
2 changes: 1 addition & 1 deletion configs/e2e/native_dependencies.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"react-native-maps": "0.31.1",
"react-native-geocoder": "0.5.0",
"react-native-device-info": "8.7.1",
"react-native-device-info": "11.1.0",
"react-native-action-button": "2.8.5",
"react-native-material-menu": "1.2.0",
"react-native-linear-gradient": "2.5.6",
Expand Down
11 changes: 6 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
"@commitlint/config-conventional": "^15.0.0",
"@rollup/plugin-node-resolve": "^13.0.6",
"@testing-library/jest-native": "^5.4.1",
"@testing-library/react": "^16.0.0",
"@testing-library/react-native": "^11.5.1",
"@types/big.js": "^6.0.2",
"@types/concurrently": "^6.3.0",
Expand All @@ -57,7 +58,6 @@
"@types/node": "^16.11.19",
"@types/react": "~18.0.0",
"@types/react-dom": "~18.0.0",
"@types/react-native": "0.72.7",
"@types/react-native-vector-icons": "^6.4.9",
"@types/react-test-renderer": "~18.0.0",
"@types/shelljs": "^0.8.9",
Expand All @@ -66,6 +66,7 @@
"deepmerge": "^4.2.2",
"detox": "^19.13.0",
"eslint": "^7.20.0",
"eslint-plugin-prettier": "4.2.1",
"husky": "^8.0.0",
"identity-obj-proxy": "^3.0.0",
"image-js": "^0.33.0",
Expand All @@ -90,14 +91,14 @@
"node": ">=20"
},
"resolutions": {
"@mendix/pluggable-widgets-tools": "9.24.0",
"@mendix/pluggable-widgets-tools": "9.24.1",
"@types/react": "^18",
"@types/react-native": "0.72.7",
"react": "18.2.0",
"react-dom": "18.2.0",
"react-native": "0.72.7",
"react-native": "0.73.8",
"typescript": "^4.9.5",
"ts-node": "^10.9.1"
"ts-node": "^10.9.1",
"@prettier/plugin-xml": "2.2.0"
},
"packageManager": "[email protected]"
}
10 changes: 10 additions & 0 deletions packages/jsActions/mobile-resources-native/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,21 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

## [8.0.0] Native Mobile Resources - 2024-07-30

### BREAKING

- We have upgraded React Native to version 0.73.8.

## [7.0.0] Native Mobile Resources - 2024-07-08

- We have fixed an issue with checking blocked permissions on iOS
- We have fixed an issue with `useNavigation` support in widgets.

### BREAKING

- We have upgraded React Native Device Info to version 11.1.0.

## [6.1.0] Native Mobile Resources - 2024-05-28

### Changed
Expand Down
4 changes: 2 additions & 2 deletions packages/jsActions/mobile-resources-native/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "mobile-resources-native",
"moduleName": "Native Mobile Resources",
"version": "7.0.0",
"version": "8.0.0",
"license": "Apache-2.0",
"copyright": "© Mendix Technology BV 2022. All rights reserved.",
"repository": {
Expand Down Expand Up @@ -32,7 +32,7 @@
"fbjs": "3.0.4",
"mime": "3.0.0",
"react-native-blob-util": "0.16.2",
"react-native-device-info": "8.7.1",
"react-native-device-info": "11.1.0",
"react-native-file-viewer": "2.1.5",
"react-native-image-picker": "5.0.1",
"react-native-inappbrowser-reborn": "3.4.0",
Expand Down
4 changes: 4 additions & 0 deletions packages/pluggableWidgets/bottom-sheet-native/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Added

- We have upgraded React Native Device Info to version 11.1.0.

## [3.2.2] - 2023-5-24

### Fixed
Expand Down
4 changes: 2 additions & 2 deletions packages/pluggableWidgets/bottom-sheet-native/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "bottom-sheet-native",
"widgetName": "BottomSheet",
"version": "3.2.2",
"version": "3.3.0",
"license": "Apache-2.0",
"repository": {
"type": "git",
Expand All @@ -22,7 +22,7 @@
"@mendix/piw-native-utils-internal": "*",
"@mendix/piw-utils-internal": "*",
"react-native-actionsheet": "^2.4.2",
"react-native-device-info": "8.7.1",
"react-native-device-info": "11.1.0",
"react-native-modal": "^11.5.4",
"react-native-reanimated": "^1.0.1",
"reanimated-bottom-sheet": "^1.0.0-alpha.19"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,6 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`Bottom sheet renders a custom bottom action sheet for ios (Basic modal) with custom style 1`] = `
<Modal
animationType="none"
hardwareAccelerated={false}
onRequestClose={[Function]}
transparent={true}
visible={false}
/>
`;
exports[`Bottom sheet renders a custom bottom action sheet for ios (Basic modal) with custom style 1`] = `null`;

exports[`Bottom sheet renders a custom modal 1`] = `
<View
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="BottomSheet" version="3.2.2" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="BottomSheet" version="3.3.0" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="BottomSheet.xml" />
</widgetFiles>
Expand Down

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions packages/pluggableWidgets/gallery-native/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Added

- We have upgraded React Native Device Info to version 11.1.0.

### Fixed

- We've resolved an issue where the loading indicator was triggered when pulling down the list, even in the absence of a pull-down event.
Expand Down
4 changes: 2 additions & 2 deletions packages/pluggableWidgets/gallery-native/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "gallery-native",
"widgetName": "Gallery",
"version": "1.0.3",
"version": "1.1.0",
"description": "A flexible gallery widget that renders columns, rows and layouts.",
"copyright": "© Mendix Technology BV 2022. All rights reserved.",
"license": "Apache-2.0",
Expand Down Expand Up @@ -29,7 +29,7 @@
},
"dependencies": {
"@mendix/piw-utils-internal": "*",
"react-native-device-info": "8.7.1"
"react-native-device-info": "11.1.0"
},
"devDependencies": {
"@mendix/pluggable-widgets-tools": "^9.0.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ export const Gallery = <T extends ObjectItem>(props: GalleryProps<T>): ReactElem
keyExtractor={item => item.id}
ListEmptyComponent={renderEmptyPlaceholder}
onEndReached={onEndReached}
scrollEventThrottle={50}
renderItem={renderItem}
style={props.style.list}
testID={`${props.name}-list`}
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/gallery-native/src/package.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="Gallery" version="1.0.3" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="Gallery" version="1.1.0" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="Gallery.xml" />
</widgetFiles>
Expand Down
4 changes: 4 additions & 0 deletions packages/pluggableWidgets/intro-screen-native/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Added

- We have upgraded React Native Device Info to version 11.1.0.

## [3.2.3] - 2023-5-24

### Fixed
Expand Down
4 changes: 2 additions & 2 deletions packages/pluggableWidgets/intro-screen-native/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "intro-screen-native",
"widgetName": "IntroScreen",
"version": "3.2.3",
"version": "3.3.0",
"license": "Apache-2.0",
"repository": {
"type": "git",
Expand All @@ -28,7 +28,7 @@
"@mendix/piw-native-utils-internal": "*",
"@mendix/piw-utils-internal": "*",
"@react-native-community/async-storage": "1.12.1",
"react-native-device-info": "8.7.1"
"react-native-device-info": "11.1.0"
},
"devDependencies": {
"@mendix/pluggable-widgets-tools": "^9.0.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,7 @@ export const SwipeableContainer = (props: SwipeableContainerProps): ReactElement
style={styles.flatList}
renderItem={renderItem}
onMomentumScrollEnd={onMomentumScrollEnd}
scrollEventThrottle={50}
extraData={width}
onLayout={onLayout}
keyExtractor={(_: any, index: number) => "screen_key_" + index}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -780,10 +780,4 @@ exports[`Intro Screen renders with active slide attribute 1`] = `
</Modal>
`;

exports[`Intro Screen renders with async storage identifier 1`] = `
<Modal
hardwareAccelerated={false}
transparent={false}
visible={false}
/>
`;
exports[`Intro Screen renders with async storage identifier 1`] = `null`;
Original file line number Diff line number Diff line change
Expand Up @@ -780,10 +780,4 @@ exports[`Intro Screen renders with active slide attribute 1`] = `
</Modal>
`;

exports[`Intro Screen renders with async storage identifier 1`] = `
<Modal
hardwareAccelerated={false}
transparent={false}
visible={false}
/>
`;
exports[`Intro Screen renders with async storage identifier 1`] = `null`;
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="IntroScreen" version="3.2.3" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="IntroScreen" version="3.3.0" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="IntroScreen.xml" />
</widgetFiles>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Added

- We have upgraded React Native Gesture Handler to version 2.16.2.

## [3.0.0] - 2023-3-28

## BREAKING
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "listview-swipe-native",
"widgetName": "ListViewSwipe",
"version": "3.0.0",
"version": "3.1.0",
"license": "Apache-2.0",
"repository": {
"type": "git",
Expand All @@ -21,7 +21,7 @@
"dependencies": {
"@mendix/piw-native-utils-internal": "*",
"@mendix/piw-utils-internal": "*",
"react-native-gesture-handler": "1.10.3"
"react-native-gesture-handler": "2.16.2"
},
"devDependencies": {
"@mendix/pluggable-widgets-tools": "^9.0.0",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="ListViewSwipe" version="3.0.0" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="ListViewSwipe" version="3.1.0" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="ListViewSwipe.xml" />
</widgetFiles>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ exports[`ProgressCircle renders 1`] = `
bbHeight={100}
bbWidth={100}
collapsable={false}
fill="none"
focusable={false}
height={100}
style={
Expand All @@ -39,7 +40,14 @@ exports[`ProgressCircle renders 1`] = `
}
width={100}
>
<RNSVGGroup>
<RNSVGGroup
fill={null}
propList={
[
"fill",
]
}
>
<RNSVGPath
d="M50 2.5
A47.5 47.5 0 0 1 50.00000000000001 97.5"
Expand Down
4 changes: 4 additions & 0 deletions packages/pluggableWidgets/rating-native/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### BREAKING

- We made the widget compatible with React Native 0.73.8

## [4.0.0] - 2023-01-24

## BREAKING
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/rating-native/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "rating-native",
"widgetName": "Rating",
"version": "4.0.0",
"version": "5.0.0",
"license": "Apache-2.0",
"repository": {
"type": "git",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// has an outdated dependency (react-native-vector-icons) that we now managed here in this widget.
import { ClassicComponentClass, Component, createElement } from "react";
import { View, StyleSheet, ViewStyle } from "react-native";
import { AnimatableProperties, View as AnimatableView } from "react-native-animatable";
import { AnimatableProps, View as AnimatableView } from "react-native-animatable";
import type { StarRatingProps } from "react-native-star-rating";

import StarButton, { iconSets } from "./StarButton";
Expand Down Expand Up @@ -67,7 +67,7 @@ interface AnimationProps {

class StarRating extends Component<Props> {
static defaultProps: typeof defaultProps;
starRef: Array<ClassicComponentClass<AnimatableProperties<ViewStyle>> & AnimationProps>;
starRef: Array<ClassicComponentClass<AnimatableProps<ViewStyle>> & AnimationProps>;

constructor(props: Props) {
super(props);
Expand Down Expand Up @@ -128,9 +128,7 @@ class StarRating extends Component<Props> {
key={i}
ref={node => {
if (node) {
this.starRef[i] = node as unknown as ClassicComponentClass<
AnimatableProperties<ViewStyle>
> &
this.starRef[i] = node as unknown as ClassicComponentClass<AnimatableProps<ViewStyle>> &
AnimationProps;
}
}}
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/rating-native/src/package.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="Rating" version="4.0.0" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="Rating" version="5.0.0" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="Rating.xml" />
</widgetFiles>
Expand Down
Loading
Loading