Fixed scroll jumping up when typing past field height #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to 0.9.0
Update to 0.9.1
Update to 0.10.0
…ace-master # Conflicts: # packages/zefyr/lib/src/widgets/input.dart
…en typing long Described in memspace#171 Solution by raj457036 Haven't tested yet, not sure about the isAtEnd logic...
Thanks Raj.
Correcting my mistakes after I got errors trying it out
ScrollController not attached to any scroll views. 'package:flutter/src/widgets/scroll_controller.dart': Failed assertion: line 110 pos 12: '_positions.isNotEmpty'
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 11 11
Lines 1074 1074
=======================================
Hits 987 987
Misses 87 87 Continue to review full report at Codecov.
|
Got rid of showAutocorrectionPromptRect & AutofillScope, which I'm not sure what it was serving when unimplemented. Was from masewo's changes.
Skquark
commented
May 24, 2020
Skquark
added a commit
to Skquark/zefyr
that referenced
this pull request
May 24, 2020
To replace my original PR memspace#315 I forked from the wrong fork, and wanted to simplify commits to one, and fix the Travis CL build failure it was reporting. Issue discussed here memspace#171
|
Simplified the fork and resubmitted the Pull.. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #171