Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Pin version of macos to avoid build failure #998

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

thedataking
Copy link
Collaborator

@thedataking thedataking commented Apr 23, 2024

It seems macos-latest transitioned (is transitioning) from x86 to aarch64. This may lead to unintended interactions with caching of the Rust toolchain. We've observed runs that failed because cargo was not found. My best guess is that we restored a x86 toolchain onto a aarch64 host but reproducing to make sure would take too much time. Requesting macos-13 instead of macos-latest should avoid this issue altogether.

@thedataking thedataking force-pushed the perl/fix-macos-cargo-not-found branch 2 times, most recently from 7955fbc to 1c50f1b Compare April 23, 2024 20:55
@thedataking thedataking changed the title CI: Use absolute path to cargo on macos-14-large CI: Use absolute path to cargo on macos-13 Apr 23, 2024
Also pins the macos version so we don't get silently switched to
aarch64 which is tested separately.
@thedataking thedataking force-pushed the perl/fix-macos-cargo-not-found branch from 1c50f1b to 248ad25 Compare April 23, 2024 21:04
@thedataking thedataking changed the title CI: Use absolute path to cargo on macos-13 CI: Pin version of macos to avoid build failure Apr 23, 2024
@thedataking thedataking merged commit fabd2f3 into main Apr 23, 2024
19 checks passed
@thedataking thedataking deleted the perl/fix-macos-cargo-not-found branch April 23, 2024 21:16
@kkysen
Copy link
Collaborator

kkysen commented Apr 23, 2024

Can we add a test for aarch64 macOS, too?

@thedataking
Copy link
Collaborator Author

Can we add a test for aarch64 macOS, too?

that's already covered in another workflow file (build-and-test-aarch64-darwin.yml).

@kkysen
Copy link
Collaborator

kkysen commented Apr 23, 2024

Can we add a test for aarch64 macOS, too?

that's already covered in another workflow file (build-and-test-aarch64-darwin.yml).

Ah, okay. Awesome then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants