-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport palette packing asm from dav1d 1.3.0 #989
Conversation
This is on top of #987 |
da8504e
to
e32620e
Compare
Thank you for the suggestion. Indeed, I think I would have to move the branches to |
6ba4cc1
to
847035f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some little things. Rest looks generally good.
src/pal.rs
Outdated
bh: c_int, | ||
w: c_int, | ||
h: c_int, | ||
) -> () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
) -> () { | |
) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm not sure why it's causing some timeouts on aarch64 macOS, since these changes shouldn't make things slower.
Move palette packing/edge-extension into a DSP function and provide asm and Rust equivalents