Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

struct RefMvsFrame::rp_proj: Add DisjointMut #974

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

kkysen
Copy link
Collaborator

@kkysen kkysen commented Apr 13, 2024

This also makes fn RefMvsFrame::as_mut_dav1d take &self and use DisjointMut's inner mutability when calling load_tmvs. This way the uses of f.rf are &s and won't prevent making f & in #952.

This then sets the stage for passing DisjointMuts directly to fn load_tmvs_c and using it safely there. The asm fn ptrs will continue to things completely unsafe, as we can't really get around that.

@kkysen kkysen force-pushed the kkysen/fn-load_tmvs_c-cleanup branch from c7c7cb9 to 2543a93 Compare April 15, 2024 07:23
@kkysen kkysen force-pushed the kkysen/struct-RefMvsFrame-rp_proj-DisjointMut branch from 0c0a0fc to 3cd96c2 Compare April 15, 2024 07:26
@randomPoison randomPoison self-assigned this Apr 15, 2024
@kkysen kkysen force-pushed the kkysen/fn-load_tmvs_c-cleanup branch from 2543a93 to 76dc80d Compare April 16, 2024 07:14
@kkysen kkysen force-pushed the kkysen/struct-RefMvsFrame-rp_proj-DisjointMut branch from 3cd96c2 to bd7546c Compare April 16, 2024 07:14
@kkysen kkysen force-pushed the kkysen/fn-load_tmvs_c-cleanup branch from 76dc80d to ba95f19 Compare April 16, 2024 07:56
@kkysen kkysen force-pushed the kkysen/struct-RefMvsFrame-rp_proj-DisjointMut branch from bd7546c to 64d123f Compare April 16, 2024 07:56
@kkysen kkysen force-pushed the kkysen/fn-load_tmvs_c-cleanup branch from ba95f19 to 268f82d Compare April 16, 2024 08:03
@kkysen kkysen force-pushed the kkysen/struct-RefMvsFrame-rp_proj-DisjointMut branch from 64d123f to 1652fad Compare April 16, 2024 08:03
@kkysen kkysen force-pushed the kkysen/fn-load_tmvs_c-cleanup branch from 268f82d to 5106700 Compare April 17, 2024 00:20
@kkysen kkysen force-pushed the kkysen/struct-RefMvsFrame-rp_proj-DisjointMut branch from 1652fad to 0fda1e2 Compare April 17, 2024 00:20
Base automatically changed from kkysen/fn-load_tmvs_c-cleanup to main April 17, 2024 00:33
@kkysen kkysen merged commit aefd86c into main Apr 17, 2024
19 checks passed
@kkysen kkysen deleted the kkysen/struct-RefMvsFrame-rp_proj-DisjointMut branch April 17, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants