fn dav1d_parse_sequence_header: backport simplification from dav1d 1.2.1
#897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
requested changes
Mar 23, 2024
fbossen
force-pushed
the
bp-1.2.1-0021
branch
4 times, most recently
from
b806651
to
8e2ebfb
Compare
|
Note sure whether the API function |
fbossen
force-pushed
the
bp-1.2.1-0021
branch
2 times, most recently
from
b2918a2
to
df3dfa7
Compare
kkysen
approved these changes
Mar 31, 2024
It's not used by anything, and the data it references is stack-allocated.
Creating an entire decoder instance just for some bitstream parsing is completely unnecessary. We can instead parse the sequence header directly into the user-provided buffer while ignoring/skipping other OBU types, with zero memory allocations required.
kkysen
requested changes
Apr 4, 2024
kkysen
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid creating an entire decoder instance to just parse a sequence header.