struct FrameTileThreadData::lowest_pixel_mem: Make into Vec
#878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove `FrameTileThreadData` because it only had a single field and was only used in one place. `lowest_pixel_mem` is now a field of `Rav1dFrameData`.
randomPoison
force-pushed
the
legare/lowest_pixel_mem
branch
from
ef0fcf1
to
d393291
Compare
kkysen
changed the title
FrameTileThreadData::lowest_pixel_mem: Make into VecFrameTileThreadData::lowest_pixel_mem: Make into Vec
kkysen
changed the title
FrameTileThreadData::lowest_pixel_mem: Make into Vecstruct FrameTileThreadData::lowest_pixel_mem: Make into Vec
kkysen
approved these changes
Mar 21, 2024
| let mut lowest_pixel_ptr = f.tile_thread.lowest_pixel_mem; | ||
| // TODO: Fallible allocation | ||
| f.lowest_pixel_mem | ||
| .resize(lowest_pixel_mem_sz as usize, Default::default()); |
There was a problem hiding this comment.
Suggested change
| .resize(lowest_pixel_mem_sz as usize, Default::default()); | |
| .resize_with(lowest_pixel_mem_sz as usize, Default::default); |
There was a problem hiding this comment.
Why though? What's the difference between these two? The data is Copy so the end result is the same.
There was a problem hiding this comment.
The docs recommend it for Default::default and it optimizes a little bit better, since .resize does a write for n - 1, cloning them, and then writes the last one without the clone. .resize_with just write all n at once, so the codegen is better, and the source is a bit cleaner.
There was a problem hiding this comment.
Noted. I'll use resize_with going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove
FrameTileThreadDatabecause it only had a single field and was only used in one place.lowest_pixel_memis now a direct field ofRav1dFrameData.@rinon let me know if this looks like it'll conflict with your changes. From what I saw it doesn't look like you changed
FrameTileThreadDataso I'm not expecting it to conflict, but we can wait to merge this until after your changes are merged if that'll help.FrameTileThreadData: Make fields safe #712