Fix aarch64 build and test aarch64 on macOS #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature flags were causing build failures with aarch64 GNU/Linux. Closes #773.
thedataking
force-pushed
the
perl/issue-773
branch
14 times, most recently
from
733e1c8
to
aad6244
Compare
thedataking
force-pushed
the
perl/issue-773
branch
5 times, most recently
from
d54a3fa
to
9c66a59
Compare
randomPoison
approved these changes
Mar 15, 2024
kkysen
reviewed
Mar 15, 2024
There was a problem hiding this comment.
We need to keep a good way to run tests with qemu locally. Is it possible to do this in build.rs somehow, maybe using cargo:rustc-flags=FLAGS? Maybe we can have a local-only solution for testing, but if build.rs can accommodate this, I think that'd be ideal.
kkysen
reviewed
Mar 15, 2024
kkysen
reviewed
Mar 15, 2024
thedataking
force-pushed
the
perl/issue-773
branch
3 times, most recently
from
857d9b3
to
38887a5
Compare
thedataking
force-pushed
the
perl/issue-773
branch
from
38887a5
to
7a9bb52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.cargo/config.tomlsince it can causecargo buildwithout--targetto fail. Closes rav1d fails to build on aarch64 #773.aarch64on macOS/arm64 which runs much faster than under QEMU.armv7without docker which avoids the time spent provisioning and starting docker on each run.