-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
struct EdgeFlags
: Make bitflags!
#759
Conversation
8fd0109
to
fbd360e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry again for the overlap @folkertdev. In making intra_edge.rs
safe and const
, I did some of this already. I didn't make EdgeFlags
a bitflags!
yet, though, so we can use those changes once rebased and everything made const fn
-compatible, since all of the uses in intra_edge.rs
are now in const fn
s. I'll open that PR shortly.
that's fine, #762 looks really nice! I'll build this on top of that again when it gets merged (one extra change is that |
@folkertdev, wanted to let you know #762 is merged now. |
fbd360e
to
7156e41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just had a couple of minor questions/comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still had some minor comments. It mostly looks very good.
Co-authored-by: Nicole L <[email protected]>
Co-authored-by: Khyber Sen <[email protected]>
2836d36
to
49b8c87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there; found two more little simplifications.
Co-authored-by: Khyber Sen <[email protected]>
No description provided.