struct EdgeFlags: Make bitflags!
#759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
commented
Feb 23, 2024
folkertdev
force-pushed
the
edge-flags-bitflags
branch
from
8fd0109
to
fbd360e
Compare
kkysen
reviewed
Feb 24, 2024
There was a problem hiding this comment.
Sorry again for the overlap @folkertdev. In making intra_edge.rs safe and const, I did some of this already. I didn't make EdgeFlags a bitflags! yet, though, so we can use those changes once rebased and everything made const fn-compatible, since all of the uses in intra_edge.rs are now in const fns. I'll open that PR shortly.
|
that's fine, #762 looks really nice! I'll build this on top of that again when it gets merged (one extra change is that |
kkysen
requested changes
Feb 26, 2024
|
@folkertdev, wanted to let you know #762 is merged now. |
folkertdev
force-pushed
the
edge-flags-bitflags
branch
from
fbd360e
to
7156e41
Compare
folkertdev
commented
Feb 28, 2024
folkertdev
commented
Feb 28, 2024
randomPoison
approved these changes
Feb 28, 2024
kkysen
requested changes
Feb 28, 2024
Co-authored-by: Nicole L <[email protected]>
Co-authored-by: Khyber Sen <[email protected]>
folkertdev
force-pushed
the
edge-flags-bitflags
branch
from
2836d36
to
49b8c87
Compare
kkysen
requested changes
Feb 29, 2024
Co-authored-by: Khyber Sen <[email protected]>
kkysen
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.