fn Rav1dFrameContext_bd_fn::get: Replace field with lookups to static versions
#752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinon
force-pushed
the
sjc/rav1dframecontext/remove_from_task_context
branch
from
0ea0911
to
2cbf114
Compare
rinon
reviewed
Feb 16, 2024
|
I like this idea of a static function pointer table, just a small comment. Needs rebasing now too. |
Base automatically changed from
sjc/rav1dframecontext/remove_from_task_context
to
main
February 16, 2024 21:35
kkysen
force-pushed
the
kkysen/fn-Rav1dFrameContext_bd_fn-get
branch
from
d119a91
to
dbfbf5c
Compare
…epth_max: c_int` to `BPC`.
…elf` just from a `bpc` since it's a pure `fn`.
…kup through the existing `bitdepth_max` field, avoiding `.clone()`s and memory.
kkysen
force-pushed
the
kkysen/fn-Rav1dFrameContext_bd_fn-get
branch
from
dbfbf5c
to
9a7ee23
Compare
rinon
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fn Rav1dFrameContext_bd_fn::newisconstand pure, so we can have a purebitdepth_max: c_int=>&'static Rav1dFrameContext_bd_fnfn, thereby avoiding.clone()s and saving on memory.See #748 (comment) and #748 (comment).
We can also do a similar thing for
Rav1dDSPContext, but with it cached based on runtime CPU features.