Rav1dFrameContext_frame_thread::pal: Make into an AlignedVec
#732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinon
reviewed
Feb 8, 2024
rinon
reviewed
Feb 8, 2024
randomPoison
force-pushed
the
legare/ravidframecontext_frame_thread/pal
branch
from
3505492
to
b1ffbf9
Compare
randomPoison
force-pushed
the
legare/ravidframecontext_frame_thread/cbi
branch
from
47bf8ed
to
90fa006
Compare
Base automatically changed from
legare/ravidframecontext_frame_thread/cbi
to
main
February 9, 2024 17:58
kkysen
reviewed
Feb 9, 2024
kkysen
previously approved these changes
Feb 9, 2024
randomPoison
force-pushed
the
legare/ravidframecontext_frame_thread/pal
branch
3 times, most recently
from
74f5904
to
5a4a50d
Compare
randomPoison
dismissed
kkysen’s stale review
Additional changes have been made that need review.
randomPoison
force-pushed
the
legare/ravidframecontext_frame_thread/pal
branch
from
c36f010
to
2f0be62
Compare
kkysen
requested changes
Feb 20, 2024
There was a problem hiding this comment.
Taking a look at this again, I realized we don't actually need bounds on T for safe transmutability, since we leave the u8s uninitialized and only ever initialize things as Ts. I had a bunch of other comments, though, and I thought of a way to make it generic over the alignment.
randomPoison
force-pushed
the
legare/ravidframecontext_frame_thread/pal
branch
2 times, most recently
from
d91cd0b
to
55dc06d
Compare
kkysen
reviewed
Feb 21, 2024
kkysen
requested changes
Feb 21, 2024
kkysen
changed the title
Rav1dFrameContext_frame_thread::pal: Make into a VecRav1dFrameContext_frame_thread::pal: Make into an aligned Vec
rinon
reviewed
Feb 22, 2024
|
LGTM overall, minor nitpicks aside. |
randomPoison
force-pushed
the
legare/ravidframecontext_frame_thread/pal
branch
from
55dc06d
to
c23b4ed
Compare
The original C logic was doing an aligned allocation, so we use the `Align64` wrapper type to enforce that same alignment.
randomPoison
force-pushed
the
legare/ravidframecontext_frame_thread/pal
branch
from
c23b4ed
to
7129605
Compare
kkysen
approved these changes
Feb 22, 2024
rinon
approved these changes
Feb 22, 2024
kkysen
changed the title
Rav1dFrameContext_frame_thread::pal: Make into an aligned VecRav1dFrameContext_frame_thread::pal: Make into an AlignedVec
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds
AlignedVec64to have theVecaligned, since aVec<Align64<T>>would add extra padding between each element since it would align each element, and we only want to align the wholeVec/slice.