-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
struct Rav1dFrameContext_task_thread
: Replace atomic intrinsics
#672
Conversation
Rav1dFrameContext_task_thread
atomicsstruct Rav1dFrameContext_task_thread
: Replace atomic intrinsics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides that indentation typo.
0a93786
to
7509587
Compare
3ac1fd4
to
edc0f88
Compare
Added another atomic_i32 -> AtomicI32 commit, so worth a quick additional look. |
e4c66b9
to
eae8a7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good with the pending_tasks_merge
change now, but what was the hoist from Rav1dFrameContext_task_thread_pending_tasks
to Rav1dFrameContext_task_thread
for, (for some mutability reasons?)? Can you add that to the PR description or commit message?
eae8a7b
to
625c1a8
Compare
Updated the commit message. I moved it out in preparation for making the |
7509587
to
ef6b864
Compare
625c1a8
to
8cdae04
Compare
ef6b864
to
4b3f2a2
Compare
8cdae04
to
d3278e1
Compare
4b3f2a2
to
d28be39
Compare
This change moves the `merge` field out of `Rav1dFrameContext_task_thread_pending_tasks` into the parent struct, `Rav1dFrameContext_task_thread`, in preparation to move the `pending_tasks` field into a Mutex.
d3278e1
to
2e2a18b
Compare
No description provided.