build.rs: Fix windows cross compilation
#1323
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t os. Cross-compiles (even of just `rav1d` the library) failed without this.
…s` so `rav1d` can cross compile to/from windows.
…rror if trying to cross compile to `*-windows-msvc`.
kkysen
force-pushed
the
kkysen/fix-windows-cross-compile
branch
from
41442ad
to
a61cac8
Compare
thedataking
requested changes
Oct 23, 2024
| nasm.flag("-Fdwarf"); | ||
| #[cfg(all(debug_assertions, windows))] | ||
| nasm.flag("-fwin64"); | ||
| nasm.flag(match os { |
There was a problem hiding this comment.
This should still be guarded by #[cfg(debug_assertions)] because -F implies -g in some nasm versions.
https://www.nasm.us/xdoc/2.14rc5/html/nasmdoc2.html#section-2.1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@thedataking, I only noticed after you merged #1295 a few things.
This should let us cross-compile from windows, cross-compile to
*-windows-gnu(I think; the linker wasn't installed so I couldn't test all the way), and print a clear error when trying to cross-compile to*-windows-msvc. It also lets us do full cross-compilation onrav1d, as thesnprintfstuff for windows is only forrav1d-cli.