struct Dav1dFrameHeader: backport memory size reduction from dav1d 1.3.0
#1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Almer <[email protected]>
kkysen
requested changes
Apr 28, 2024
| .frame_offset, | ||
| frame_offset, | ||
| .frame_offset as c_int, | ||
| frame_offset as c_int, |
There was a problem hiding this comment.
We could make fn get_poc_diff and all of the poc fields/vars u8s. I can add that if you want (I checked to see if it it's possible).
There was a problem hiding this comment.
Yes, but that's really beyond the scope of this PR. I'll let you create a new one.
kkysen
approved these changes
Apr 30, 2024
rinon
reviewed
May 8, 2024
| @@ -358,7 +359,7 @@ unsafe fn read_tx_tree( | |||
| }; | |||
| } | |||
|
|
|||
| fn neg_deinterleave(diff: c_int, r#ref: c_int, max: c_int) -> c_int { | |||
| fn neg_deinterleave(diff: u8, r#ref: u8, max: u8) -> u8 { | |||
There was a problem hiding this comment.
We can't change these to unsigned, max - 1 may be negative.
There was a problem hiding this comment.
Does #1056 solve it?
fbossen
pushed a commit
to fbossen/rav1d
that referenced
this pull request
May 8, 2024
`max` can be 0 and subtracting 1 causes underflow
fbossen
pushed a commit
to fbossen/rav1d
that referenced
this pull request
May 8, 2024
`max` can be 0 and subtracting 1 causes underflow
fbossen
pushed a commit
that referenced
this pull request
May 9, 2024
`max` can be 0 and subtracting 1 causes underflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dav1dFrameHeaderof Backport: Reduce the size of some public structs #505.Shrinks
Rav1dFrameHeaderfrom 1664 to 1120 bytes.