Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup c2rust output in itx.rs #817

Closed
1 of 4 tasks
Tracked by #839
randomPoison opened this issue Mar 15, 2024 · 3 comments
Closed
1 of 4 tasks
Tracked by #839

Cleanup c2rust output in itx.rs #817

randomPoison opened this issue Mar 15, 2024 · 3 comments
Assignees
@thedataking @kkysen

Comments

@randomPoison
Copy link
Collaborator

randomPoison commented Mar 15, 2024 •
edited by kkysen
Loading

Note that this should wait until after #683 is merged in order to not duplicate work between the 8bpc and 16bpc versions.

  • Cleanup helper functions to take safe arguments where possible (may take raw pointers as arguments currently).
  • General cleanup of c2rust generated code in functions.
  • Restore comments from original C.

The following functions still need to be cleaned:

  • inv_txfm_add_wht_wht_4x4_rust
@randomPoison randomPoison mentioned this issue Mar 15, 2024
Closed
@randomPoison randomPoison changed the title itx.rs Cleanup Rust fallback functions in itx.rs Mar 15, 2024
@thedataking
Copy link
Collaborator

I'm working on deduplicating and cleaning up this module in PR #683 so I can do this one unless someone else wants to.

@thedataking thedataking self-assigned this Mar 15, 2024
@randomPoison randomPoison changed the title Cleanup Rust fallback functions in itx.rs Cleanup c2rust output in itx.rs Mar 18, 2024
@randomPoison randomPoison mentioned this issue Mar 18, 2024
Closed
11 tasks
@kkysen
Copy link
Collaborator

kkysen commented May 6, 2024

I'm working on deduplicating and cleaning up this module in PR #683 so I can do this one unless someone else wants to.

@thedataking, have you actually started this? I can do this. I started doing itx_1d but they overlap a lot

@kkysen kkysen self-assigned this May 6, 2024
This was referenced May 7, 2024
Merged
Merged
kkysen added a commit that referenced this issue May 7, 2024
@kkysen
fn inv_txfm_add_rust: Cleanup and make mostly safe (#1041)
c1ab115 
* Fixes `fn inv_txfm_add_rust` of #817.
* Fixes `fn inv_txfm_add_rust` of #836.
kkysen added a commit that referenced this issue May 7, 2024
@kkysen
fn inv_txfm_add_wht_wht_4x4_rust: Cleanup and make mostly safe (#1042)
a09bda1 
* Fixes `fn inv_txfm_add_wht_wht_4x4_rust` of #817.
* Fixes `fn inv_txfm_add_wht_wht_4x4_rust` of #836.

Very similar to #1041.
@randomPoison
Copy link
Collaborator Author

Looks like this was finished in #1042, and the module has been made fully safe as of #1143, so I'm going to close this.

@randomPoison randomPoison mentioned this issue Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thedataking thedataking

@kkysen kkysen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@randomPoison @thedataking @kkysen