Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itx.rs: Replace C types with Rust equivalents #1183

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

randomPoison
Copy link
Collaborator

@randomPoison randomPoison commented Jun 7, 2024

@randomPoison randomPoison requested a review from kkysen June 7, 2024 21:55
@kkysen kkysen self-assigned this Jun 9, 2024
Copy link
Collaborator

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm not sure if it's too important to do this. That said, if we are, it makes sense to replace libc::ptrdiff_t with isize, too, I think.

@randomPoison
Copy link
Collaborator Author

Ah good catch I missed that we also had ptrdiff_t in there. Cleaned that up as well. And yeah, this isn't priority work but since it takes literally seconds to do I figured I'd quickly do this as part of closing out the c2rust cleanup issues.

@randomPoison randomPoison merged commit a1be40e into main Jun 10, 2024
26 checks passed
@randomPoison randomPoison deleted the legare/itx-c-types branch June 10, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants