Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and remove #[allow(non_*)]s #1299

Open
2 of 3 tasks
kkysen opened this issue Jul 10, 2024 · 0 comments
Open
2 of 3 tasks

Fix and remove #[allow(non_*)]s #1299

kkysen opened this issue Jul 10, 2024 · 0 comments
Labels
good first issue Good for newcomers low priority Issues that we would like to address at some point in the future

Comments

@kkysen
Copy link
Collaborator

kkysen commented Jul 10, 2024 •
edited
Loading

  • #![allow(non_camel_case_types)]
  • #![allow(non_snake_case)]
  • #![allow(non_upper_case_globals)]

Would be nice to make things more idiomatically Rusty. A bunch of renames, but simple to do.
@kkysen kkysen added good first issue Good for newcomers low priority Issues that we would like to address at some point in the future labels Jul 10, 2024
This was referenced Jul 10, 2024
Merged
Merged
kkysen added a commit that referenced this issue Jul 10, 2024
@kkysen
#![allow(non_camel_case_types)]: Fix and remove (#1302)
dbb9803 
* Fixes `#![allow(non_camel_case_types)]` of #1299.

Supersedes #1301 by just fixing the warnings instead of papering over
what appears to be a `rust-analyzer` false positive bug.
kkysen added a commit that referenced this issue Jul 10, 2024
@kkysen
#![allow(non_snake_case)]: Fix and remove (#1303)
eb700e4 
* Fixes `#![allow(non_snake_case)]` of #1299.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers low priority Issues that we would like to address at some point in the future
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kkysen