Remove searchable attr warning for nested attrs #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
+ Coverage 88.90% 88.91% +0.01%
==========================================
Files 13 13
Lines 757 758 +1
==========================================
+ Hits 673 674 +1
Misses 84 84 ☔ View full report in Codecov by Sentry. |
brunoocasali
previously approved these changes
Aug 7, 2024
|
@ellnix sorry can you fix the git conflicts so that we can merge? |
Since attributes can be defined with a block the only thing we know about them is the top level attribute name. Therefore, we trust that the user knows what they are doing when they use nested attributes.
ellnix
force-pushed
the
remove-nested-searchable-attr-warning
branch
from
863aba6
to
f8c820d
Compare
Done ✔️ |
meili-bors bot
added a commit
that referenced
this pull request
Sep 15, 2024
369: Remove searchable attr warning for nested attrs r=brunoocasali a=ellnix # Pull Request ## Related issue Fixes #366 Co-authored-by: ellnix <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"} |
brunoocasali
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #366