Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add install task #279

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Add install task #279

merged 1 commit into from
Aug 31, 2023

Conversation

sabljak
Copy link
Contributor

@sabljak sabljak commented Aug 24, 2023

New meilisearch:install task creates an initializer file

Pull Request

Related issue

What does this PR do?

  • adds a meilisearch:install task to create the meilisearch.rb initializer with template configuration
  • adds changes to README.md file to include environment variables

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

brunoocasali
brunoocasali requested changes Aug 24, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked it a lot, very nice to see it! I just had one comment:

I think it is better to provide a realistic sample like the http://localhost:7700

lib/meilisearch/rails/templates/initializer.rb Outdated Show resolved Hide resolved
@sabljak
Copy link
Contributor Author

sabljak commented Aug 24, 2023

@brunoocasali fixed!

Should we add the same to README.md or leave it as is?

@brunoocasali
Copy link
Member

brunoocasali commented Aug 28, 2023 •
edited
Loading

Should we add the same to README.md or leave it as is?

I think it is good to have the same in the README indeed!

@brunoocasali brunoocasali added the enhancement New feature or request label Aug 28, 2023
@brunoocasali
Copy link
Member

@sabljak I'll wait for the change before merging, thanks a lot!

@sabljak sabljak force-pushed the add-install-generator branch 2 times, most recently from 873ddbd to 598f789 Compare August 28, 2023 22:09
@sabljak
Add install task
dc9266d 
New meilisearch:install task creates an initializer file
@sabljak
Copy link
Contributor Author

sabljak commented Aug 28, 2023

@brunoocasali Done! Ready for merge 😁

brunoocasali
brunoocasali approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Aug 31, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 3f41be9 into meilisearch:main Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabljak @brunoocasali