Latest compat work #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original plan was to release this as blaze-builder-compat, but Simon wants to release it as a new version of blaze-builder itself
Hide bytestring-builder behind an if impl(ghc < 7.8) to avoid downloading and compiling bytestring-builder when it probably isn't needed. This assumes that GHC 7.8 users have at least bytestring-0.10.4, and haven't installed an older version of bytestring for some reason, which should be a pretty safe assumption. Also, text 1.1 is out now.
meiersi
added a commit
that referenced
this pull request
Jan 30, 2015
Latest compat work. Thanks @lpsmith the code has become a lot smaller, which I like. One thing I noticed is that we should add a big disclaimer to the documentation pointing people to the proper bytestring builder, which they should use in new projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a pull request related to #17; which is the latest version of my compat work.
The biggest change is that this patch removes the repackaged new builder, since that repackaging was spun out into
bytestring-builder.