videoroom: always take room mutex before streams mutex (see #3463) #3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we tested it since yesterday, no hangs yet. Deploying to more servers for test |
|
@atoppi we tested it for two days on production and have no problems, so I think this time fix is on point, thanks! Waiting for merging now so we can use master again. |
|
Thanks for the feedback, merging then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch tries to fix the mutex order reversal discussed in #3463.
We tried to enforce the order
videoroom->mutex--->publisher/subscriber->streams_mutex.This is highly experimental and poorly tested, pinging @spscream since we know they stress a lot those critical paths subject to deadlocking.