-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata for videoroom publishers #3467
base: master
Are you sure you want to change the base?
Conversation
I've used display with stringified json before for exactly this purpose so it would be great to have a proper meta data field |
It does make sense, yes, but as it is it looks like it's an immutable object. I'd add an option to modify the metadata object in a configure request (and notify the change to other attendees), just as you can edit the display name dynamically. |
35f15cf
to
d3a1a0d
Compare
added ability to update metadata |
5e3bfa0
to
04f5886
Compare
Thanks for the changes, looks good to me! Once you fix the conflicts, I think this is ready to be merged. |
04f5886
to
d127f04
Compare
@lminiero rebased |
d127f04
to
8e7cd86
Compare
8e7cd86
to
520648e
Compare
Thanks! The only thing I'm wondering about, now, is that if you use a configure to update both |
I want to introduce ability to set metadata for publishers on join.
I added metadata field with json_t and save info to it on join and send it in "joined"/"published" events.
We use it on our branch now to build custom business logic for videoroom, for example we set in metadata now: