Skip to content

Commit

Permalink
videoroom: add missing pin parameter to joinSubscriber (#48)
Browse files Browse the repository at this point in the history
Co-authored-by: Sergey Slobodenyuk <[email protected]>
  • Loading branch information
mDev86 and Sergey Slobodenyuk authored Nov 11, 2024
1 parent 5159a72 commit 4792d5b
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/plugins/videoroom-plugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -936,9 +936,10 @@ class VideoRoomHandle extends Handle {
* @param {boolean} [params.autoupdate] - [multistream] Whether a new SDP offer is sent automatically when a subscribed publisher leaves
* @param {boolean} [params.use_msid] - [multistream] Whether subscriptions should include an msid that references the publisher
* @param {string} [params.token] - The optional token needed
* @param {string} [params.pin] - The optional password required to join the room
* @returns {Promise<module:videoroom-plugin~VIDEOROOM_EVENT_SUB_JOINED>}
*/
async joinSubscriber({ room, feed, audio, video, data, private_id, sc_substream_layer, sc_substream_fallback_ms, sc_temporal_layers, streams, autoupdate, use_msid, token }) {
async joinSubscriber({ room, feed, audio, video, data, private_id, sc_substream_layer, sc_substream_fallback_ms, sc_temporal_layers, streams, autoupdate, use_msid, token, pin }) {
const body = {
request: REQUEST_JOIN,
ptype: PTYPE_LISTENER,
Expand All @@ -960,6 +961,7 @@ class VideoRoomHandle extends Handle {
}
if (typeof private_id === 'number') body.private_id = private_id;
if (typeof token === 'string') body.token = token;
if (typeof pin === 'string') body.pin = pin;

/* [multistream] */
if (typeof autoupdate === 'boolean') body.autoupdate = autoupdate;
Expand Down

0 comments on commit 4792d5b

Please sign in to comment.