Resolves issues with secure cookies, blocking Shopify password form #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a critical issue with BrowserSync's handling of SameSite=None/Secure cookies. Hopefully we'll get a fix directly into BrowserSync but in the meantime this should resolve the issue. The issue stopped allowing the Shopify password form from being able to be submitted since the returning
storefront_digest={hash}
SameSite=None/Secure cookie was getting invalidated and thus breaking Shopify's ability to establish a session in the response.A PR has been logged with BrowserSync here: BrowserSync/browser-sync#1964. The BrowserSync function of note is: https://github.com/BrowserSync/browser-sync/blob/master/packages/browser-sync/lib/server/proxy-utils.js#L122
In my diagnosis of the issue I also added support for self certified TLS certificates so that the browser won't prompt that localhost is not secure. In order to use this functionality the following tutorials can be followed: