Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves issues with secure cookies, blocking Shopify password form #27

Merged
merged 2 commits into from
May 17, 2022

Conversation

maxrolon
Copy link
Collaborator

This PR resolves a critical issue with BrowserSync's handling of SameSite=None/Secure cookies. Hopefully we'll get a fix directly into BrowserSync but in the meantime this should resolve the issue. The issue stopped allowing the Shopify password form from being able to be submitted since the returning storefront_digest={hash} SameSite=None/Secure cookie was getting invalidated and thus breaking Shopify's ability to establish a session in the response.

A PR has been logged with BrowserSync here: BrowserSync/browser-sync#1964. The BrowserSync function of note is: https://github.com/BrowserSync/browser-sync/blob/master/packages/browser-sync/lib/server/proxy-utils.js#L122

In my diagnosis of the issue I also added support for self certified TLS certificates so that the browser won't prompt that localhost is not secure. In order to use this functionality the following tutorials can be followed:

@netlify
Copy link

netlify bot commented May 17, 2022

Deploy Preview for half-helix-kit ready!

Name Link
🔨 Latest commit dd04103
🔍 Latest deploy log https://app.netlify.com/sites/half-helix-kit/deploys/6282fe4b1e93860008819a3e
😎 Deploy Preview https://deploy-preview-27--half-helix-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@maxrolon maxrolon merged commit 1d475f6 into master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant