-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing issues with code coverage report generation and upload to Code Climate #489
Open
caiosba
wants to merge
17
commits into
dmou/test-consolidate-dockerfiles
Choose a base branch
from
caio/test-consolidade-dockerfiles
base: dmou/test-consolidate-dockerfiles
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixing issues with code coverage report generation and upload to Code Climate #489
caiosba
wants to merge
17
commits into
dmou/test-consolidate-dockerfiles
from
caio/test-consolidade-dockerfiles
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caiosba
changed the base branch from
dmou/test-consolidate-dockerfiles
to
develop
November 6, 2024 16:13
caiosba
changed the base branch from
develop
to
dmou/test-consolidate-dockerfiles
November 6, 2024 16:14
caiosba
changed the title
[WIP] Trying to fix Code Coverage upload issue
Fixing issues with code coverage report generation and upload to Code Climate
Nov 7, 2024
caiosba
requested review from
melsawy,
vasconsaurus and
jayjay-w
as code owners
November 7, 2024 01:13
caiosba
requested review from
dmou
and removed request for
melsawy,
jayjay-w and
vasconsaurus
November 7, 2024 01:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the steps that generate and upload the code coverage report to Code Climate.
The main issue was that previously, we ran the tests, prepared the coverage report, and uploaded it all within the Docker container. Now, however, the tests run inside the Docker container, while the coverage report is prepared outside of it, leading to a mismatch in file paths. The solution I implemented was to use sed to replace the paths, changing
/app/pender
to/home/runner/work/pender
. I also needed to copycodeclimate.json
to the coverage directory and set the$CC_TEST_REPORTER_ID
environment variable.Reference: CV2-5020.
How has this been tested?
Code Coverage report was generated and uploaded to Code Climate as expected:
Checklist