Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruby to version 3.2.5 #477

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

jayjay-w
Copy link
Contributor

@jayjay-w jayjay-w commented Sep 25, 2024

Update ruby to version 3.2.5

Description

Updating Pender's ruby version to 3.2.5.

References: CV2-4958

How has this been tested?

  • Confirmed that tests pass
  • Pender is parsing URLs as expected

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@jayjay-w jayjay-w force-pushed the CV2-4958-ruby-upgrade-3.2.5 branch 2 times, most recently from 7cc12a8 to de475ce Compare September 30, 2024 15:15
Update ruby to version 3.2.5
@jayjay-w jayjay-w marked this pull request as ready for review October 1, 2024 07:41
Copy link
Contributor

@vasconsaurus vasconsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we mostly got 401 "Auth Failed ip_blacklisted: 20.49.55.0/24" errors (which I think are coming from our proxy, we should probably look into this)

But we did get this one:

Failure:

MediasControllerTest#test_should_return_error_message_on_hash_if_url_does_not_exist [/app/test/controllers/medias_controller_test.rb:72]:

Expected: "instagram"

Actual: "page"

rails test test/controllers/medias_controller_test.rb:65

@jayjay-w Do you think it's related to the auth error, or could it be something else?

Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go if tests pass. Are we running tests against SQLite or Postgres? Let's be sure it passes on Postgres since the PG gem version was upgraded.

@jayjay-w
Copy link
Contributor Author

jayjay-w commented Oct 1, 2024

@vasconsaurus I will confirm whether that's happening only in this branch.

@jayjay-w jayjay-w merged commit 9038f6c into develop Oct 1, 2024
4 checks passed
@jayjay-w jayjay-w deleted the CV2-4958-ruby-upgrade-3.2.5 branch October 1, 2024 16:54
jayjay-w added a commit that referenced this pull request Oct 1, 2024
Fix Gemfile.lock mismatch with Gemfile. This mismatch was introduced in #477
jayjay-w added a commit that referenced this pull request Oct 1, 2024
Fix Gemfile.lock mismatch with Gemfile. This mismatch was introduced in #477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants