-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ruby to version 3.2.5 #477
Conversation
7cc12a8
to
de475ce
Compare
Update ruby to version 3.2.5
de475ce
to
d203fa4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we mostly got 401 "Auth Failed ip_blacklisted: 20.49.55.0/24"
errors (which I think are coming from our proxy, we should probably look into this)
But we did get this one:
Failure:
MediasControllerTest#test_should_return_error_message_on_hash_if_url_does_not_exist [/app/test/controllers/medias_controller_test.rb:72]:
Expected: "instagram"
Actual: "page"
rails test test/controllers/medias_controller_test.rb:65
@jayjay-w Do you think it's related to the auth error, or could it be something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go if tests pass. Are we running tests against SQLite or Postgres? Let's be sure it passes on Postgres since the PG gem version was upgraded.
@vasconsaurus I will confirm whether that's happening only in this branch. |
Fix Gemfile.lock mismatch with Gemfile. This mismatch was introduced in #477
Fix Gemfile.lock mismatch with Gemfile. This mismatch was introduced in #477
Update ruby to version 3.2.5
Description
Updating Pender's ruby version to 3.2.5.
References: CV2-4958
How has this been tested?
Checklist