Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3887 – Better error handling in PermaCC #412

Merged
merged 7 commits into from
Oct 26, 2023
Merged

3887 – Better error handling in PermaCC #412

merged 7 commits into from
Oct 26, 2023

Commits on Oct 26, 2023

  1. add PermaCcError

    @vasconsaurus
    vasconsaurus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    c91b664 View commit details
    Browse the repository at this point in the history

  2. update error handling in perma_cc 

    While working on refactorinf the tests:
"At first the mocked test seemed to pass, but it was failing because
I wasn't mocking the response correct so response.message was nil.
After I mocked it correctly it stopped adding it to data.

That was happening because we were raising the first error as
RetryLater and we don't set the data when we rescue from RetryLater,
only StandardError (media_archiver.rb:93)."

Besides that, we don't want to retry if the user's perma_cc usage limit
is hit.
    @vasconsaurus
    vasconsaurus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f0c6d7b View commit details
    Browse the repository at this point in the history

  3. update test

    @vasconsaurus
    vasconsaurus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    32b736c View commit details
    Browse the repository at this point in the history

  4. update test and update perma_cc 

    we don't want TooManyCaptures to raise an error and be retried, but
we do want the data to be updated with the error
    @vasconsaurus
    vasconsaurus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    87daf05 View commit details
    Browse the repository at this point in the history

  5. fix test

    @vasconsaurus
    vasconsaurus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    0148fd6 View commit details
    Browse the repository at this point in the history

  6. update perma cc logic to be similar to archive org

    @vasconsaurus
    vasconsaurus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    bf28237 View commit details
    Browse the repository at this point in the history

  7. skip tests related to video archiving 

    we are not supporting archiving videos with youtube-dl anymore,
will remove this on a separate ticket
    @vasconsaurus
    vasconsaurus committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    bc99a6a View commit details
    Browse the repository at this point in the history