3634 – Refactor Kwai testing

[vasconsaurus]

Description

This is part of a larger project to improve our testing.

Context
We have two issues:

• We want to be able to choose when to run integration tests.
• We have too many integration tests.

To fix this we need to go through all the parsers and:

• Split the integration from the unit tests, we now have a folder for them (test > integration > parsers).
• Go through the unit tests and make sure they are not making live http requests.
• Go through the integration tests, see which one of those should be integration tests (keep those at 2, 3 tests at the most), and refactor the rest to be unit tests. (ideally we want one to test a successful request and one to test a failure)

Notes on the Kwai tests

This one was pretty straight forward:

• I moved integration test to it's own file
• Created a new integration test that makes sure it returns data even if it fails
• No clean up was needed

References: 3634, 3629

[codeclimate]

Code Climate has analyzed commit f269d1e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 98.6% (0.0% change).

View more on Code Climate.

[caiosba]

Nice and clean!