3718 – Update how we retry tests #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running locally we might not want the tests to retry, to do this we would need to comment out the retry lines. We want to make this easier on the developer Conerting the env variable to an integer because ENV[] on ruby returns a string https://ruby-doc.org/core-3.0.0/ENV.html
|
Code Climate has analyzed commit ebc7bce and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 98.6% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running locally we might not want the tests to retry, to do this
we would need to comment out the retry lines. We want to make this easier
on the developer
Converting the env variable to an integer because ENV[] on ruby returns a string
https://ruby-doc.org/core-3.0.0/ENV.html
References: 3718
How has this been tested?
Changed a test to make it fail.
Ran tests locally without setting
TEST_RETRY_COUNT, test failed and didn't retry.Set the env var inside the container (
export TEST_RETRY_COUNT=5) and ran the tests again, it retried 5 times.