3716 – Fix Kwai & Facebook's failing tests #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this test had started to fail. I'm not too sure about everything here: - we have the url from the link, and inside the page we have the canonical_url - we were getting the error because the canonical_url was being invoked, but was not stubbed. Stubbing it fixed that error - we then get a new error, the media.url actually matches the canonical_url and not the original_url. so I updated our asserts as this seems to be the expected behavior
vasconsaurus
changed the title
caiosba
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For a while now we have one test from Kwai and one from Facebook that have been failing.
Facebook
I'm not too sure about everything here, but it seems:
urlfrom the link, and inside the page we have thecanonical_urlcanonical_urlwas being invoked, but was not stubbed.Stubbing it fixed that error
media.urlactually matches thecanonical_urland not theoriginal_url.So I updated our asserts as this seems to be the expected behavior.
Kwai
The test here seems to be working fine, but our parsing seems to be broken. 🥲
We search the doc for
'.info .title'and for'.name', and both of those are returningnil.I looked through the page, but haven't found a direct substitute for both of those.
So I'll open a separate ticket for us to look into this, since the issue here isn't fixing the test, and might not be super straightforward.
References: 3716