Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3653 - extract username correctly when there is a query #385

Merged
merged 3 commits into from
Sep 6, 2023
Merged

3653 - extract username correctly when there is a query #385

merged 3 commits into from
Sep 6, 2023

Commits on Sep 5, 2023

  1. make regex more robust 

    sometimes a profile url might come with a query, we need to make sure
we are getting only the username to make the request to the twitter api
endpoint
    @vasconsaurus
    vasconsaurus committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    200a9fd View commit details
    Browse the repository at this point in the history

  2. fix regex 

    it was missing the final character when there wasn't a query
    @vasconsaurus
    vasconsaurus committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    6e0067d View commit details
    Browse the repository at this point in the history

  3. fix regex to be less broad 

    trying to fit everything into two patterns didn't work, it ended up
matching the twitter item as well. So I broke it into two more patterns,
and ordered them from the two that are more specific to the less.
    @vasconsaurus
    vasconsaurus committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    38cfe44 View commit details
    Browse the repository at this point in the history