3386 - make sure oembed_json is a Hash #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in a few specific cases our oembed_json was returning an integer, which was an unexpected return, thus breaking things. by returning early, we return nil, something we can deal with.
vasconsaurus
requested review from
hartsick,
caiosba and
melsawy
as code owners
caiosba
approved these changes
Aug 17, 2023
|
Two facebook tests failed. I think there is some flakiness going on with the facebook tests. I don't think the failures are related to this change. |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We sometimes get an error when parsing the
oembed:TypeError: no implicit conversion of String into IntegerThis happens with similar specific urls, all weirdly named urls with
.topdomain. Those sites return '404' on theirresponse.body, when weJSON.parseit, it returns an integer, which breaks things.This was fixed by returning early if the value is not a
Hash.References: 3386
How has this been tested?
Tested parsing some of the urls that were causing this error. (there are some examples on the ticket)