Skip to content

Commit

Permalink
remove facebook_test_app and update config example (#419)
Browse files Browse the repository at this point in the history
we only used facebook_test_app in one test, we weren't declaring it in
our config file. Besides, since we can specify the values by environment
I think the different variable name is not needed.
  • Loading branch information
vasconsaurus authored Dec 5, 2023
1 parent d71225c commit 9d4bb60
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions config/config.yml.example
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ test:
storage_video_bucket:
storage_video_asset_path:
storage_medias_asset_path: 'http://localhost:9000/check-test/medias'
facebook_app: # '<FACEBOOK APP ID>:<FACEBOOK APP SECRET>'
otel_log_level: off
otel_traces_sampler:
sentry_dsn:
Expand Down
2 changes: 1 addition & 1 deletion test/models/metrics_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ class AllTestFacebookAppsRateLimited < StandardError; end

test "should get metrics from Facebook" do
begin
fb_config = PenderConfig.get('facebook_test_app') || PenderConfig.get('facebook_app')
fb_config = PenderConfig.get('facebook_app')
PenderConfig.current = nil
key = create_api_key application_settings: { config: { facebook_app: fb_config }}

Expand Down

0 comments on commit 9d4bb60

Please sign in to comment.