Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove internal module resources option #9582

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

chore: remove internal module resources option #9582

wants to merge 17 commits into from
+75 −258

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues commented Oct 15, 2024 •
edited
Loading

What:

  • removes resouces type "shared" or "isolated" from internal modules.
  • modules can have an isolated database connection by providing a database config as part of their options on medusa-config

CLOSES: FRMW-2593

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 17e6080

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 8:58am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Oct 16, 2024 8:58am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 8:58am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 8:58am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 8:58am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 8:58am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2024 8:58am

@carlos-r-l-rodrigues carlos-r-l-rodrigues marked this pull request as ready for review October 15, 2024 19:13
@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner October 15, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl olivermrbl is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
team: medusa type: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@carlos-r-l-rodrigues