Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meilisearch.md #7862

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Update meilisearch.md #7862

merged 3 commits into from
Sep 23, 2024

Conversation

pavlotsyhanok
Copy link
Sponsor

Problem:

The existing documentation for the Meilisearch plugin contains example that, if copy-pasted exactly, will not work.

Solution:

I have updated the Meilisearch plugin configuration example to reflect the correct settings.

Benefits:

With this updated code snippet, users can simply copy and paste it into their local medusa-config.js file. It will work seamlessly with the standard configuration and is compatible with the latest version of Meilisearch.

Testing:

The updated configuration has been tested and confirmed to work in a live deployment environment on Digital Ocean(Server) and Vercel(Storefront)

image image

Added a better example that user can copy and paste to their local config file
@pavlotsyhanok pavlotsyhanok requested a review from a team as a code owner June 28, 2024 05:41
Copy link

changeset-bot bot commented Jun 28, 2024

⚠️ No Changeset found

Latest commit: 172c6a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 28, 2024

@pavlotsyhanok is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

"handle",
],
},
primaryKey: "id",
transformer: (product) => ({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transformer isn't required, did you have to provide it for the plugin to work?

Copy link
Sponsor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shahednasser yes, I had to provide it, otherwise it wouldn't work.

Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pavlotsyhanok for this contribution! Can I get you to open an issue with more details on why you had to use the transformer?

@pavlotsyhanok
Copy link
Sponsor Author

Thanks @pavlotsyhanok for this contribution! Can I get you to open an issue with more details on why you had to use the transformer?

Yes, will do.

Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 22, 2024
@SalahAdDin
Copy link

Problem:

The existing documentation for the Meilisearch plugin contains example that, if copy-pasted exactly, will not work.

Solution:

I have updated the Meilisearch plugin configuration example to reflect the correct settings.

Benefits:

With this updated code snippet, users can simply copy and paste it into their local medusa-config.js file. It will work seamlessly with the standard configuration and is compatible with the latest version of Meilisearch.

Testing:

The updated configuration has been tested and confirmed to work in a live deployment environment on Digital Ocean(Server) and Vercel(Storefront)
image image

which medusa version is that for?

@kodiakhq kodiakhq bot merged commit 6c0ce5a into medusajs:v1.x Sep 23, 2024
24 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants