fix(dashboard): Set correct method value on promotion

medusajs · Oct 16, 2024 · 1efcbc0 · 1efcbc0
1 parent ea5bff9
commit 1efcbc0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/packages/admin/dashboard/src/hooks/table/columns/use-promotion-table-columns.tsx b/packages/admin/dashboard/src/hooks/table/columns/use-promotion-table-columns.tsx
@@ -28,11 +28,11 @@ export const usePromotionTableColumns = () => {
 
       columnHelper.display({
         id: "method",
-        header: () => <TextHeader text={t("promotions.fields.campaign")} />,
+        header: () => <TextHeader text={t("promotions.fields.method")} />,
         cell: ({ row }) => {
           const text = row.original.is_automatic
-            ? "Automatic"
-            : "Promotion Code"
+            ? t("promotions.form.method.automatic.title")
+            : t("promotions.form.method.code.title")
 
           return <TextCell text={text} />
         },

diff --git a/packages/admin/dashboard/src/i18n/translations/en.json b/packages/admin/dashboard/src/i18n/translations/en.json
@@ -1716,6 +1716,7 @@
       "value_type": "Value Type",
       "value": "Value",
       "campaign": "Campaign",
+      "method": "Method",
       "allocation": "Allocation",
       "addCondition": "Add condition",
       "clearAll": "Clear all",

diff --git a/...tions/promotion-detail/components/promotion-general-section/promotion-general-section.tsx b/...tions/promotion-detail/components/promotion-general-section/promotion-general-section.tsx
@@ -85,7 +85,7 @@ export const PromotionGeneralSection = ({
     [PromotionStatus.EXPIRED]: ["red", t("statuses.expired")],
   }[getPromotionStatus(promotion)] as [
     "grey" | "orange" | "green" | "red",
-    string
+    string,
   ]
 
   const displayValue = getDisplayValue(promotion)
@@ -130,7 +130,9 @@ export const PromotionGeneralSection = ({
         </Text>
 
         <Text size="small" leading="compact" className="text-pretty">
-          {promotion.is_automatic ? "Promotion code" : "Automatic"}
+          {promotion.is_automatic
+            ? t("promotions.form.method.automatic.title")
+            : t("promotions.form.method.code.title")}
         </Text>
       </div>