some type fixes + deduplicate setTargetBitrate #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, make setTargetBitrate and setTargetBitrateAsync consistent before deduplication
make both functions consistent, applying the changes that 2951d62 did to setTargetBitrate also to setTargetBitrateAsync
mildsunrise
force-pushed
the
dev/alba/fix-types
branch
from
fbbade0
to
f4bc272
Compare
|
how about removing the non async version completely instead? |
|
oh, but we're still using it in StreamView, aren't we? and I thought we wanted to avoid blocking the event loop so frequently |
|
I mean to keep only the async version |
|
ah sorry, misread. I'm perfectly okay with it, I'll replace the last commit |
mildsunrise
force-pushed
the
dev/alba/fix-types
branch
from
f4bc272
to
08e2520
Compare
|
it is done |
mildsunrise
force-pushed
the
dev/alba/fix-types
branch
from
08e2520
to
1184e1f
Compare
|
tests are failing after swapping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR first makes setTargetBitrateAsync consistent with setTargetBitrate,
and then factors out most of the logic (common to both) to a new private function called
__setTargetBitrate.to do this, we move the call to
getActiveLayers(orgetActiveLayersAsync) up in the function, which could have small side effects. please see the commit message for more info