Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [DIOS-7056] Separate unit and integration tests #278

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bcostdolby
Copy link
Contributor

No description provided.

@eck1001
Copy link

eck1001 commented Oct 11, 2024

Not super relevant for testing. But I see that this is a ts project. We should be able to use path mapping to handle relative imports a bit better. check out: https://www.typescriptlang.org/tsconfig/#paths

We just need to double check that our TS version has the feature included.

UPDATE: Sorry, I forgot we are using commonjs require syntax here. Really should upgrade to ESM's and use import/export. It allows tree shaking and slightly better performance. Let me know if anyone knows of any cons but with the native support introduced, I think with node v12, it should be easy to update modules. -- This is definitely a topic outside of this PR. I'll post it elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants