fix(core): singleSelect - search filter not working well due to duplicate key issue. #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cate key issue. affects: @medly-components/core ISSUES CLOSED: medly#732
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 91c6005. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
|
@Bhusnar5044 Values should always be unique hence we can remove adding the index as key. This should also remove the sonar error. |
affects: @medly-components/core
done 👍 |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affects: @medly-components/core
ISSUES CLOSED: #732
PR Checklist
Description
singleSelect - search filter not showing the filtered options, If there is any duplicate option available with a different value, the search not showing those options.
Type of change
Fixes #732
What is the current behaviour?
Search not filtering the options if it contains duplicate label option.
What is the new behaviour?
Search shows the filtered options even if there are any duplicate options with the same label.
Does this PR introduce a breaking change?
Checklist
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules