Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rm-unnecessary-check #243

Closed
wants to merge 9 commits into from
Closed

Rm-unnecessary-check #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
effeea9
Rm-unnecessary-test
robkam Jun 4, 2024
4503784
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 4, 2024
daf333a
rm hard coded version check
robkam Jun 4, 2024
ea50444
rm hard coded 1.39.6
robkam Jun 5, 2024
1a4bfd0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 5, 2024
20e5026
rm 1.39.6 check
robkam Jun 5, 2024
54ca4fe
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 5, 2024
281ab81
still has hardcoded version #
robkam Jun 5, 2024
f5fc84b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions wikiteam3/dumpgenerator/dump/misc/site_info_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,13 @@


def test_mediawiki_version_match():
with get_config("1.39.6") as config:
mediawiki_ver = (
"1.39.7" # You can set this to the actual version you expect for now
)
with get_config(mediawiki_ver) as config:
sess = requests.Session()
saveSiteInfo(config, sess)
with open(f"{config.path}/siteinfo.json") as f:
siteInfoJson = json.load(f)
assert siteInfoJson["query"]["general"]["generator"] == "MediaWiki 1.39.6"
expected_version = siteInfoJson["query"]["general"]["generator"]
assert expected_version.startswith("MediaWiki")
13 changes: 6 additions & 7 deletions wikiteam3/dumpgenerator/test/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,9 @@ def _new_config_from_parameter(params):

def get_config(mediawiki_ver, api=True):
assert api == True
if mediawiki_ver == "1.39.6":
return _new_config_from_parameter(
[
"--api",
"https://testw.fandom.com/api.php",
]
)
return _new_config_from_parameter(
[
"--api",
"https://testw.fandom.com/api.php",
]
)
Loading