-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docstring to __init__.py #240
Conversation
To try and placate CI - is this really needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
@robkam—If you're not sure why a check is failing, you can click on "Details" next to each test, and it should give you some sort of explanation. The failure here is that the MediaWiki version in the test data is not the expected version. In other words, the site we are testing against updated to a new version of MediaWiki. I'm not sure why, but the expected version number appears to be hardcoded in the following two places: mediawiki-dump-generator/wikiteam3/dumpgenerator/test/test_config.py Lines 27 to 35 in a8d2ef0
mediawiki-dump-generator/wikiteam3/dumpgenerator/dump/misc/site_info_test.py Lines 11 to 17 in 3f7bfd7
This code appears to have been added by @sian1468—could you help us understand why the version is hardcoded here? And if possible could you find a way to avoid having it hardcoded? Thanks! |
The original owner of this code is @NyaMisty from commit f57f50f but from my understanding is code used to check if Mediawiki version from test website is match or not. In my opinion this code should be removed as it is unnecessary to test this function is working or not. |
I was only checking the details for pre-commit.ci - I'll close this PR as the docstring isn't the problem. |
I've (rather clumsily) tried to remove the hardcoded version check in #243 but it's not fixed the CI. |
For now, I've just updated the version number to get it past the CI. |
Trying to get around hardcoded version to pass CI.
Trying to not mess up #244 |
Fixed in #245 |
Fixes failing test in #240
To try and placate CI - is this really needed here?