Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dark mode #590

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

tribhuwan-kumar
Copy link
Contributor

@tribhuwan-kumar tribhuwan-kumar commented Oct 27, 2024


fix: #520
name: add dark mode
about: "why is this pr ?" well some user love dark mode also me, working in light mode is tough so i decided to implement it :)
title:
labels: ''
assignees: ''


demo

demo.mp4

description

brief description of the changes in this pr.

related issue: #520

type of change

  • bug fix
  • new feature
  • breaking change
  • documentation update

how to test

checklist

  • i have read the CONTRIBUTING.md file
  • i have added the custom cursor AI prompt to my settings as mentioned in CONTRIBUTING.md and used to write this PR
  • my code follows the project's style guidelines
  • i have performed a self-review of my code
  • i have updated the documentation if necessary
  • my changes generate no new warnings
  • i have added tests that prove my fix is effective or that my feature works
  • all tests pass locally with my changes

additional notes

any other relevant information about the pr.

Copy link

vercel bot commented Oct 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screenpipe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 1:15pm

@louis030195
Copy link
Collaborator

Screenshot 2024-10-28 at 8 29 09 AM Screenshot 2024-10-28 at 8 29 20 AM Screenshot 2024-10-28 at 8 29 30 AM

that seem too dark

honestly not sure i want to accept this PR, it means i will have to maintain this theme myself all the time

@tribhuwan-kumar
Copy link
Contributor Author

that seem too dark

its the default radix ui dark theme provided in globals.css. i can modify it to make it less darker

honestly not sure i want to accept this PR, it means i will have to maintain this theme myself all the time

that's not the case, the @radix-ui/themes will use the .dark color class for dark mode, if you add custom styles in a tag then yes, you will also have to style it for dark mode. if you're okay with it, then i can work further

@tribhuwan-kumar
Copy link
Contributor Author

@louis030195
converting it to draft, will implement later with better dark theme when app is saturated

@tribhuwan-kumar tribhuwan-kumar marked this pull request as draft November 1, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set a black background ui
2 participants