This repository has been archived by the owner on Dec 14, 2023. It is now read-only.
Fix solr collections #842
Open
Fix solr collections #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(can be overridden via MC_NO_DEDUP_SENTENCES env var) apps/common/src/python/mediawords/util/config/__init__.py: add env_bool function apps/extract-and-vector/bin/extract_and_vector_worker.py: honor MC_NO_DEDUP_SENTENCES
…CTION Set to "mediacloud2" (solr alias!)
…processing backlog up FETCH_BLOCK_SIZE from 100 to 200: ammortizes citus connection startup time by processing fetching larger blocks of text. Honor skip_update_snapshot option (defaults to true): skip setting snapshots.searchable=true
(Jinja2 2.11.3 can't cope with the new MarkupSafe 2.1.1)
PG server running on postgresql EC2 server w/o docker
Removed extra AND to try to fix mediacloud#833 as suggested by Rahul.
esirK
reviewed
Nov 9, 2022
esirK
reviewed
Nov 9, 2022
| abs_uri = furl(f"{solr_url}/{collection}/{path}") | ||
| abs_uri = abs_uri.set(params) | ||
| abs_url = str(abs_uri) | ||
| request = Request(method='POST', url=abs_url) |
There was a problem hiding this comment.
We can drop the abs_url = str(abs_uri) unless the abs_url is used somewhere else.
request = Request(method='POST', url=str(abs_url))
esirK
reviewed
Nov 9, 2022
| abs_uri = abs_uri.set(params) | ||
| abs_url = str(abs_uri) | ||
| request = Request(method='POST', url=abs_url) | ||
| request.set_header(name='Content-Type', value=content_type) |
There was a problem hiding this comment.
From this, I think we can combine all the headers while creating the Request something like
headers = {
'Content-Type': content_type
'Content-Length': str(len(content_encoded)),
}
request = Request(method='POST', url=abs_url, headers=headers)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
java.lang.ClassCastExceptionbug by querying mediacloud32 and mediacloud64 solr collections separately, then combine responses.