Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Addes fixes for ISSUE #12 #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

atishgoswami
Copy link

  • Changed the composer.lock and composer.json file locations
  • Added additional PSR mapping to src folder
  • Added changes to .travis.yml file

@bobbyshaw
Copy link
Member

Thanks for experimenting with this. Like @munawar99 mentioned #12 (comment) I think that there's a little more that needs to be done here.

I'm unsure because I experimented myself but didn't get it working but there are a couple of lines in the setup file that are referring to the src directory that likely need to be updated: https://github.com/meanbee/magento2-royalmail/blob/master/bin/setup.sh#L11

Are you sure about that composer auth line change? That errors in travis:

[RuntimeException]                           
  http-basic.repo.magento.com is not defined.

@atishgoswami
Copy link
Author

atishgoswami commented Jun 5, 2017

Hi @bobbyshaw,

I have checked the command on my local machine and works fine.

composer config --global --auth http-basic.repo.magento.com 14c4b06b824ec593239362517f538b29 5f4dcc3b5aa765d61d8327deb882cf99

Seems like the environment variables $COMPOSER_MAGENTO_USERNAME $COMPOSER_MAGENTO_PASSWORD not proper configured with TRAVIS. So whenever the command is executed though TRAVIS the command becomes:

composer config --global --auth http-basic.repo.magento.com

And you get the following errors:

  [RuntimeException]                           
  http-basic.repo.magento.com is not defined.                                               

config [-g|--global] [-e|--editor] [-a|--auth] [--unset] [-l|--list] [-f|--file FILE] [--absolute] [--] [<setting-key>] [<setting-value>]...

As the over command tries to fetch the information present in the auth.json file which doesnot exist yet on the TRAVIS server.

@bobbyshaw
Copy link
Member

Hmm ok. These variables are set but it seems Travis doesn't export them in PRs for security reasons: https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants