Skip to content

Commit

Permalink
Fix id for nested comment example (#23)
Browse files Browse the repository at this point in the history
The aria-details attribute references the element with id of 'thread-3'.
The nested comment element reuses the id of 'thread-1'.
This looks like a copy / paste error.
It prevents the browser from exposing an aria details reference for the marked content because there is no element with that id.

Co-authored-by: Brian Thomas Smith <[email protected]>
  • Loading branch information
feerrenrut and bsmth authored Nov 22, 2023
1 parent 650db97 commit 2d5cb3f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion aria-annotations/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ <h3>Marcus said</h3>

<p>The last half of the song is a slow-rising crescendo that peaks at the <mark aria-details="thread-3">end of the guitar solo</mark>, before fading away sharply.</p>

<div role="comment" id="thread-1" data-author="chris">
<div role="comment" id="thread-3" data-author="chris">
<h3>Chris said</h3>
<p class="comment-text">I really think this moment could use more cowbell.</p>
<p><time datetime="2019-03-30T19:29">March 30 2019, 19:29</time></p>
Expand Down

0 comments on commit 2d5cb3f

Please sign in to comment.